This repository was archived by the owner on Jul 19, 2024. It is now read-only.
Added new variable to find out video source#17
Open
mikestecker wants to merge 1 commit intohappycog:masterfrom
Open
Added new variable to find out video source#17mikestecker wants to merge 1 commit intohappycog:masterfrom
mikestecker wants to merge 1 commit intohappycog:masterfrom
Conversation
Member
|
Great idea and thanks for the pull request. We already do the logic for checking the video host here: https://github.com/vector/Antenna/blob/master/third_party/antenna/pi.antenna.php#L97-L109 And in the area right below yours; could you combine your variable setting into one of those? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a new variable to find out the video's source site name. Useful for third-party JS tools that need to know this info.